Implemented QFP80 component #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
seveibar
reviewed
Sep 21, 2024
lib/qfp80.tsx
Outdated
| @@ -0,0 +1,107 @@ | |||
| import { ChipBody } from "./ChipBody"; | |||
There was a problem hiding this comment.
the file name should just be qfp
seveibar
requested changes
Sep 21, 2024
So they have a different body width |
seveibar
requested changes
Sep 21, 2024
lib/qfp.tsx
Outdated
| @@ -3,7 +3,7 @@ import { SmdChipLead } from "./SmdChipLead"; | |||
|
|
|||
| export const QFP = ({ | |||
| pinCount, | |||
| fullWidth = 10, | |||
| fullWidth = pinCount === 80 ? 14 : 10, | |||
There was a problem hiding this comment.
hmm this is a hack, you should derive the width automatically, we shouldn't hard code width values
seveibar
approved these changes
Sep 22, 2024
This was referenced Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#39